67 lines
4.3 KiB
Markdown
67 lines
4.3 KiB
Markdown
# Tasks for: Result Preparation Refactoring
|
|
|
|
**Feature**: `002-result-preparation-refactoring`
|
|
**Spec**: [spec.md](spec.md)
|
|
**Plan**: [plan.md](plan.md)
|
|
|
|
## Implementation Strategy
|
|
|
|
The implementation will be done in phases, focusing on refactoring the backend logic first, followed by the frontend updates. The backend and frontend tasks can be worked on in parallel.
|
|
|
|
**MVP Scope**: The Minimum Viable Product will include the refactored `LLMService` that can categorize desires and the updated `ResultsDisplay` component to show the new categories.
|
|
|
|
---
|
|
|
|
## Phase 1: Foundational Tasks (Backend Refactoring)
|
|
|
|
These tasks focus on updating the backend to handle the new desire categorization logic.
|
|
|
|
- [x] **T001**: [Test] Create a new test file `backend/tests/LLMService.refactor.test.ts` to test the new desire categorization functionality.
|
|
- [x] **T002**: [Backend] Refactor `backend/src/services/LLMService.ts` to replace the existing `analyzeDesires` method with one that uses the new prompt from `research.md` to categorize desires into `Go-to`, `Also good`, `Considerable`, `No-goes`, and `Needs discussion`.
|
|
- [x] **T003**: [Backend] Update the WebSocket handler in `backend/src/ws/index.ts` to call the refactored `LLMService.analyzeDesires` method and broadcast the new `Decision` object to clients.
|
|
|
|
---
|
|
|
|
## Phase 2: User Story 1 & 2 - Desire Submission & Contradiction Check
|
|
|
|
**Goal**: A user can submit their desires, and the system checks for inner contradictions.
|
|
**Independent Test**: Submit a desire set with an inner contradiction (e.g., "I want a dog" and "I don't want any pets" in the same category) and verify that the system returns an error.
|
|
|
|
- [x] **T004**: [Test] Add a test case to `backend/tests/LLMService.refactor.test.ts` for the inner contradiction check.
|
|
- [x] **T005**: [Backend] Implement a new method `checkForInnerContradictions` in `backend/src/services/LLMService.ts` that uses an LLM to detect contradictions within a single desire set.
|
|
- [x] **T006**: [Backend] Update the `SUBMIT_RESPONSE` message handler in `backend/src/ws/index.ts` to call `checkForInnerContradictions` before accepting a user's submission. If contradictions are found, send an error message back to the user.
|
|
- [x] **T006a**: [Backend] In the `SUBMIT_RESPONSE` message handler in `backend/src/ws/index.ts`, add validation to ensure each desire field does not exceed 500 characters.
|
|
- [x] **T006b**: [Frontend] [P] Update the `frontend/src/components/DesireForm.tsx` component to display a character counter under each input field.
|
|
|
|
---
|
|
|
|
## Phase 3: User Story 3 - Cooperative Decision (Frontend Refactoring)
|
|
|
|
**Goal**: The frontend can correctly display the categorized results from the refactored backend.
|
|
**Independent Test**: Given a set of desires from multiple users, the frontend correctly renders the `Go-to`, `Also good`, `Considerable`, `No-goes`, and `Needs discussion` categories.
|
|
|
|
- [x] **T007**: [Frontend] [P] Update the `Decision` and related types in `frontend/src/hooks/useSession.ts` to match the new backend structure defined in `data-model.md`.
|
|
- [x] **T008**: [Test] [P] Create a test file `frontend/src/components/ResultsDisplay.refactor.test.tsx` to test the updated `ResultsDisplay` component.
|
|
- [x] **T009**: [Frontend] Refactor the `frontend/src/components/ResultsDisplay.tsx` component to display the new categories (`goTos`, `alsoGoods`, `considerables`, `noGoes`, `needsDiscussion`).
|
|
|
|
---
|
|
|
|
## Phase 4: Polish & Integration
|
|
|
|
- [x] **T010**: Perform end-to-end testing of the entire workflow.
|
|
- [x] **T011**: Clean up any old code related to the previous desire grouping logic.
|
|
- [x] **T012**: Remove the old test files `backend/tests/llmService.test.ts` and `frontend/src/components/ResultsDisplay.test.tsx` after verifying the new tests provide adequate coverage.
|
|
- [x] **T013**: [Test] Conduct performance testing to ensure that the desire submission process completes in under 1 minute as per SC-004.
|
|
|
|
---
|
|
|
|
## Dependencies
|
|
|
|
- **US1 & US2** are prerequisites for **US3**. The backend logic for contradiction checking and desire submission must be in place before the final results can be generated and displayed.
|
|
|
|
## Parallel Execution
|
|
|
|
- The backend tasks in **Phase 1 & 2** can be worked on in parallel with the frontend tasks in **Phase 3**.
|
|
- **Backend Team**: Can work on T001-T006.
|
|
- **Frontend Team**: Can work on T007-T009 using mock data until the backend is ready.
|